net: thunderx: start phy before starting autonegotiation
authorMian Yousaf Kaukab <ykaukab@suse.de>
Thu, 5 Dec 2019 09:41:16 +0000 (10:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Dec 2019 15:05:44 +0000 (16:05 +0100)
commit01e73a8cc49c8d818b56c4a9fd43910a47820a39
tree0b6d2a53a0acb9a1f19319f30c0e96c255f89cf8
parentd38ae2264d8650abcbc5f27e90e444f474355a61
net: thunderx: start phy before starting autonegotiation

[ Upstream commit a350d2e7adbb57181d33e3aa6f0565632747feaa ]

Since commit 2b3e88ea6528 ("net: phy: improve phy state checking")
phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
before calling phy_start_aneg() during probe so that autonegotiation
is initiated.

As phy_start() takes care of calling phy_start_aneg(), drop the explicit
call to phy_start_aneg().

Network fails without this patch on Octeon TX.

Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/cavium/thunder/thunder_bgx.c