rtnetlink: Warn when interface's information won't fit in our packet
authorDavid Gibson <david@gibson.dropbear.id.au>
Thu, 24 Apr 2014 00:22:35 +0000 (10:22 +1000)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 9 Jun 2014 12:28:57 +0000 (13:28 +0100)
commit03feb50421447b8c910d02099a87da97462e98ee
treee714148d6b5d65f984c5fed8d0bd8473eb6b3319
parenta5ab05f2e2a48a6b7e5efe12cbe07523a06fa963
rtnetlink: Warn when interface's information won't fit in our packet

[ Upstream commit 973462bbde79bb827824c73b59027a0aed5c9ca6 ]

Without IFLA_EXT_MASK specified, the information reported for a single
interface in response to RTM_GETLINK is expected to fit within a netlink
packet of NLMSG_GOODSIZE.

If it doesn't, however, things will go badly wrong,  When listing all
interfaces, netlink_dump() will incorrectly treat -EMSGSIZE on the first
message in a packet as the end of the listing and omit information for
that interface and all subsequent ones.  This can cause getifaddrs(3) to
enter an infinite loop.

This patch won't fix the problem, but it will WARN_ON() making it easier to
track down what's going wrong.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/rtnetlink.c