media: davinci: vpif_capture: fix potential double free
authorEvgeny Novikov <novikov@ispras.ru>
Thu, 23 Jul 2020 17:04:53 +0000 (19:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:19:25 +0000 (11:19 +0200)
commit0685dde3e21df9b1143adb3b07b70528d0c8b37e
tree1ebd7d8fe86df34ededb6652b818c715cf4ecaf8
parentef898164bf570fabc9751a1ccc9df93e14986e93
media: davinci: vpif_capture: fix potential double free

[ Upstream commit 602649eadaa0c977e362e641f51ec306bc1d365d ]

In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
and unregisters the V4L2 device. But then this is done again by
vpif_probe() itself. The patch removes the cleaning from
vpif_probe_complete().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/davinci/vpif_capture.c