Fix oops caused by queue refcounting failure
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 25 May 2011 20:52:14 +0000 (15:52 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 23 Jun 2011 22:05:32 +0000 (15:05 -0700)
commit0769e21bf4b5cf48878c1ca819276e80465b39e7
tree8ca2ad23026ad58d7cd19e7dbd670011ee752399
parente0b1510e56c0f40a7d84a766a53521a268c41d75
Fix oops caused by queue refcounting failure

commit e73e079bf128d68284efedeba1fbbc18d78610f9 upstream.

In certain circumstances, we can get an oops from a torn down device.
Most notably this is from CD roms trying to call scsi_ioctl.  The root
cause of the problem is the fact that after scsi_remove_device() has
been called, the queue is fully torn down.  This is actually wrong
since the queue can be used until the sdev release function is called.
Therefore, we add an extra reference to the queue which is released in
sdev->release, so the queue always exists.

Reported-by: Parag Warudkar <parag.lkml@gmail.com>
Signed-off-by: James Bottomley <jbottomley@parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/scsi_scan.c
drivers/scsi/scsi_sysfs.c