perf: fix perf bug in fork()
authorPeter Zijlstra <peterz@infradead.org>
Thu, 2 Oct 2014 23:17:02 +0000 (16:17 -0700)
committerJiri Slaby <jslaby@suse.cz>
Mon, 13 Oct 2014 14:09:18 +0000 (16:09 +0200)
commit07b5661fe33df525931853f6869f7f5fd68d291e
treec3775ac3c7df1330ce52ffb6fdbcad517d2d5ab5
parent8ec4e9789b8b4c05ee979daad2a27088e29fac5d
perf: fix perf bug in fork()

commit 6c72e3501d0d62fc064d3680e5234f3463ec5a86 upstream.

Oleg noticed that a cleanup by Sylvain actually uncovered a bug; by
calling perf_event_free_task() when failing sched_fork() we will not yet
have done the memset() on ->perf_event_ctxp[] and will therefore try and
'free' the inherited contexts, which are still in use by the parent
process.  This is bad..

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Sylvain 'ythier' Hitier <sylvain.hitier@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
kernel/events/core.c
kernel/fork.c