ipv4: provide stronger user input validation in nl_fib_input()
authorEric Dumazet <edumazet@google.com>
Wed, 22 Mar 2017 02:22:28 +0000 (19:22 -0700)
committerJiri Slaby <jslaby@suse.cz>
Fri, 7 Apr 2017 07:17:57 +0000 (09:17 +0200)
commit083b7de74780d65dfdd6f448288489464fa2da40
tree626a04f350879a6982a2207bcf7ffa4e5e0c8ba3
parent7d409c047a3b7a40dbd0ac8b26ec29ef62a088c8
ipv4: provide stronger user input validation in nl_fib_input()

[ Upstream commit c64c0b3cac4c5b8cb093727d2c19743ea3965c0b ]

Alexander reported a KMSAN splat caused by reads of uninitialized
field (tb_id_in) from user provided struct fib_result_nl

It turns out nl_fib_input() sanity tests on user input is a bit
wrong :

User can pretend nlh->nlmsg_len is big enough, but provide
at sendmsg() time a too small buffer.

Reported-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_frontend.c