TTY: fix atime/mtime regression
authorJiri Slaby <jslaby@suse.cz>
Fri, 26 Apr 2013 11:48:53 +0000 (13:48 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 13 May 2013 14:02:31 +0000 (15:02 +0100)
commit0b28f5865ef23d2bcee122d75b4aea1e2f052624
tree463d1815e275b9166a972ed622a464ab11eb4480
parentc29ad805df8c54a9f5d74c66bf5d4a2d449bd99a
TTY: fix atime/mtime regression

commit 37b7f3c76595e23257f61bd80b223de8658617ee upstream.

In commit b0de59b5733d ("TTY: do not update atime/mtime on read/write")
we removed timestamps from tty inodes to fix a security issue and waited
if something breaks.  Well, 'w', the utility to find out logged users
and their inactivity time broke.  It shows that users are inactive since
the time they logged in.

To revert to the old behaviour while still preventing attackers to
guess the password length, we update the timestamps in one-minute
intervals by this patch.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: For 3.2, use Greg's backported version]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/tty/tty_io.c