ALSA: usb-audio: Fix OOB access of mixer element list
authorTakashi Iwai <tiwai@suse.de>
Wed, 24 Jun 2020 12:23:40 +0000 (14:23 +0200)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:02 +0000 (15:38 -0400)
commit0f7315789b33d14ea79d0914c98391091b7ac8aa
treecd7c0006377cfca0f71b15cdd12ea6a082ada753
parentcaa09db16ce9dce014af8f7b23a474f8846491ba
ALSA: usb-audio: Fix OOB access of mixer element list

[ Upstream commit 220345e98f1cdc768eeb6e3364a0fa7ab9647fe7 ]

The USB-audio mixer code holds a linked list of usb_mixer_elem_list,
and several operations are performed for each mixer element.  A few of
them (snd_usb_mixer_notify_id() and snd_usb_mixer_interrupt_v2())
assume each mixer element being a usb_mixer_elem_info object that is a
subclass of usb_mixer_elem_list, cast via container_of() and access it
members.  This may result in an out-of-bound access when a
non-standard list element has been added, as spotted by syzkaller
recently.

This patch adds a new field, is_std_info, in usb_mixer_elem_list to
indicate that the element is the usb_mixer_elem_info type or not, and
skip the access to such an element if needed.

Reported-by: syzbot+fb14314433463ad51625@syzkaller.appspotmail.com
Reported-by: syzbot+2405ca3401e943c538b5@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200624122340.9615-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/mixer.c
sound/usb/mixer.h
sound/usb/mixer_quirks.c