Char: ipmi_bt_sm, fix infinite loop
authorJiri Slaby <jslaby@suse.cz>
Mon, 14 Apr 2014 14:46:50 +0000 (09:46 -0500)
committerJiri Slaby <jslaby@suse.cz>
Fri, 18 Apr 2014 08:26:21 +0000 (10:26 +0200)
commit1070f32690efdfef2dc64183dded068ec54266c7
tree7b0a451b6434007a312ee93212b0fb8f8dcac8f7
parent37f6d1063e2e2e7e0ee755eacc528dc120606b4c
Char: ipmi_bt_sm, fix infinite loop

commit a94cdd1f4d30f12904ab528152731fb13a812a16 upstream.

In read_all_bytes, we do

  unsigned char i;
  ...
  bt->read_data[0] = BMC2HOST;
  bt->read_count = bt->read_data[0];
  ...
  for (i = 1; i <= bt->read_count; i++)
    bt->read_data[i] = BMC2HOST;

If bt->read_data[0] == bt->read_count == 255, we loop infinitely in the
'for' loop.  Make 'i' an 'int' instead of 'char' to get rid of the
overflow and finish the loop after 255 iterations every time.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-and-debugged-by: Rui Hui Dian <rhdian@novell.com>
Cc: Tomas Cech <tcech@suse.cz>
Cc: Corey Minyard <minyard@acm.org>
Cc: <openipmi-developer@lists.sourceforge.net>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/char/ipmi/ipmi_bt_sm.c