SCSI: sd: Fix potential out-of-bounds access
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 6 Sep 2013 15:49:51 +0000 (11:49 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Sep 2013 23:52:45 +0000 (16:52 -0700)
commit173798ef2abbec8faf2a4397a24bd357fecfe008
tree0febb096989c635fa05ed104b0c8e2b5487cc6b1
parent04b25c9dde9337ea972147f47fa75709dd7377f3
SCSI: sd: Fix potential out-of-bounds access

commit 984f1733fcee3fbc78d47e26c5096921c5d9946a upstream.

This patch fixes an out-of-bounds error in sd_read_cache_type(), found
by Google's AddressSanitizer tool.  When the loop ends, we know that
"offset" lies beyond the end of the data in the buffer, so no Caching
mode page was found.  In theory it may be present, but the buffer size
is limited to 512 bytes.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/sd.c