HID: betop: fix slab-out-of-bounds Write in betop_probe
authorF.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
Tue, 24 Aug 2021 15:07:30 +0000 (20:37 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 13:05:10 +0000 (15:05 +0200)
commit1c83c38dec83d57bc18d0c01d82c413d3b34ccb9
tree5573695f33a7d1638949e92dbb824116eba715e5
parent3707e37b3fcef4d5e9a81b9c2c48ba7248051c2a
HID: betop: fix slab-out-of-bounds Write in betop_probe

commit 1e4ce418b1cb1a810256b5fb3fd33d22d1325993 upstream.

Syzbot reported slab-out-of-bounds Write bug in hid-betopff driver.
The problem is the driver assumes the device must have an input report but
some malicious devices violate this assumption.

So this patch checks hid_device's input is non empty before it's been used.

Reported-by: syzbot+07efed3bc5a1407bd742@syzkaller.appspotmail.com
Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-betopff.c