team: move add to port list before port enablement
authorJiri Pirko <jiri@resnulli.us>
Sat, 8 Jun 2013 13:00:54 +0000 (15:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jun 2013 17:39:06 +0000 (10:39 -0700)
commit1cadc4351e3bb9a55460139fb8cdb00266c45e24
treec2bc027b97b3897c0296588dd48aadf654bc30f2
parent397ab236f5273dfc2ab81ec637a61b3eb22bfc08
team: move add to port list before port enablement

[ Upstream commit 72df935d985c1575ed44ad2c8c653b28147993fa ]

team_port_enable() adds port to port_hashlist. Reader sees port
in team_get_port_by_index_rcu() and returns it, but
team_get_first_port_txable_rcu() tries to go through port_list, where the
port is not inserted yet -> NULL pointer dereference.
Fix this by reordering port_list and port_hashlist insertion.
Panic is easily triggeable when txing packets and adding/removing port
in a loop.

Introduced by commit 3d249d4c "net: introduce ethernet teaming device"

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/team/team.c