ext4: fix error handling on inode bitmap corruption
authorJan Kara <jack@suse.cz>
Sun, 18 Dec 2011 22:37:02 +0000 (17:37 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:11:31 +0000 (16:11 -0500)
commit1d0a00e9979b465cb6d5ca22829437fd96e0f76e
tree2215f5f5bf19e575c29249e2307778976ee2d429
parent45c2d5ba97f2187ce6155d7e9f0963a628f2c0ce
ext4: fix error handling on inode bitmap corruption

commit acd6ad83517639e8f09a8c5525b1dccd81cd2a10 upstream.

When insert_inode_locked() fails in ext4_new_inode() it most likely means inode
bitmap got corrupted and we allocated again inode which is already in use. Also
doing unlock_new_inode() during error recovery is wrong since the inode does
not have I_NEW set. Fix the problem by jumping to fail: (instead of fail_drop:)
which declares filesystem error and does not call unlock_new_inode().

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/ext4/ialloc.c