ALSA: pcm: Check PCM state at xfern compat ioctl
authorTakashi Iwai <tiwai@suse.de>
Wed, 2 May 2018 06:48:46 +0000 (08:48 +0200)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:39 +0000 (21:36 -0400)
commit1d139fd4a10bc8d4352e9805fb4a5bbe4e1f1409
treefcf24161b0f4babcfb3313655f0511867da34d72
parent0dbe56d6ae778cae9be71f9ee0b6caf5aeb406e3
ALSA: pcm: Check PCM state at xfern compat ioctl

[ Upstream commit f13876e2c33a657a71bcbb10f767c0951b165020 ]

Since snd_pcm_ioctl_xfern_compat() has no PCM state check, it may go
further and hit the sanity check pcm_sanity_check() when the ioctl is
called right after open.  It may eventually spew a kernel warning, as
triggered by syzbot, depending on kconfig.

The lack of PCM state check there was just an oversight.  Although
it's no real crash, the spurious kernel warning is annoying, so let's
add the proper check.

Reported-by: syzbot+1dac3a4f6bc9c1c675d4@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
sound/core/pcm_compat.c