ext4: fix error handling on inode bitmap corruption
authorJan Kara <jack@suse.cz>
Sun, 18 Dec 2011 22:37:02 +0000 (17:37 -0500)
committerWilly Tarreau <w@1wt.eu>
Sun, 7 Oct 2012 21:37:51 +0000 (23:37 +0200)
commit1f2e32346f7d082246d96e4cedbd54b8739b8ea0
tree2370306998ad23066797fcdedb3e3176f584f4b3
parentba57e38b830f274138a0349c4aef75d4c75e95a0
ext4: fix error handling on inode bitmap corruption

commit acd6ad83517639e8f09a8c5525b1dccd81cd2a10 upstream.

When insert_inode_locked() fails in ext4_new_inode() it most likely means inode
bitmap got corrupted and we allocated again inode which is already in use. Also
doing unlock_new_inode() during error recovery is wrong since the inode does
not have I_NEW set. Fix the problem by jumping to fail: (instead of fail_drop:)
which declares filesystem error and does not call unlock_new_inode().

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/ext4/ialloc.c