md/raid5: don't record new size if resize_stripes fails.
authorNeilBrown <neilb@suse.de>
Fri, 8 May 2015 08:19:34 +0000 (18:19 +1000)
committerWilly Tarreau <w@1wt.eu>
Fri, 18 Sep 2015 11:52:00 +0000 (13:52 +0200)
commit26a42fd3d6d5723b970cd8251abb87984d440bb4
tree3aee2963969ea8f5e6db3abe029009c48e852a71
parent7b5f777748799261710c6153e4e42354cc849047
md/raid5: don't record new size if resize_stripes fails.

commit 6e9eac2dcee5e19f125967dd2be3e36558c42fff upstream.

If any memory allocation in resize_stripes fails we will return
-ENOMEM, but in some cases we update conf->pool_size anyway.

This means that if we try again, the allocations will be assumed
to be larger than they are, and badness results.

So only update pool_size if there is no error.

This bug was introduced in 2.6.17 and the patch is suitable for
-stable.

Fixes: ad01c9e3752f ("[PATCH] md: Allow stripes to be expanded in preparation for expanding an array")
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit c20694a054e903745591f4f85b39ecbce4e58349)

Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/md/raid5.c