kernel/module: Fix mem leak in module_add_modinfo_attrs
authorYueHaibing <yuehaibing@huawei.com>
Tue, 11 Jun 2019 15:00:07 +0000 (23:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Sep 2019 06:21:45 +0000 (08:21 +0200)
commit3015291b2fb5aaa01a2ff15706f6c6e4f6c8f91f
treedcbf82315aa4a4821fafe1504af31b94e6b527a5
parent9c49f7811f823b45a4ddd825152de2e11ceaa73e
kernel/module: Fix mem leak in module_add_modinfo_attrs

[ Upstream commit bc6f2a757d525e001268c3658bd88822e768f8db ]

In module_add_modinfo_attrs if sysfs_create_file
fails, we forget to free allocated modinfo_attrs
and roll back the sysfs files.

Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/module.c