virtio: console: Don't access vqs if device was unplugged
authorAmit Shah <amit.shah@redhat.com>
Fri, 4 Mar 2011 03:34:33 +0000 (14:04 +1030)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 14 Mar 2011 21:17:31 +0000 (14:17 -0700)
commit310f5e480c6facfdf9ee9e6952e490eebd3d8d55
treefb03595d4a88f37d5a39f76b963ffc00fb7b0db6
parent381d256c50541d46b505b9da5c3e405fe603d886
virtio: console: Don't access vqs if device was unplugged

commit d7a62cd0332115d4c7c4689abea0d889a30d8349 upstream.

If a virtio-console device gets unplugged while a port is open, a
subsequent close() call on the port accesses vqs to free up buffers.
This can lead to a crash.

The buffers are already freed up as a result of the call to
unplug_ports() from virtcons_remove().  The fix is to simply not access
vq information if port->portdev is NULL.

Reported-by: juzhang <juzhang@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/virtio_console.c