vfs: read file_handle only once in handle_to_path
authorSasha Levin <sasha.levin@oracle.com>
Wed, 28 Jan 2015 20:30:43 +0000 (15:30 -0500)
committerJiri Slaby <jslaby@suse.cz>
Wed, 3 Jun 2015 09:33:15 +0000 (11:33 +0200)
commit330c542ff8f659055de1992935abaa18b121379e
tree8e31f039fc0728328ce1b32633d906b7796f627f
parentc58fe902f9b36ae78496b32c0d2d7c05e1c301f5
vfs: read file_handle only once in handle_to_path

commit 161f873b89136eb1e69477c847d5a5033239d9ba upstream.

We used to read file_handle twice.  Once to get the amount of extra
bytes, and once to fetch the entire structure.

This may be problematic since we do size verifications only after the
first read, so if the number of extra bytes changes in userspace between
the first and second calls, we'll have an incoherent view of
file_handle.

Instead, read the constant size once, and copy that over to the final
structure without having to re-read it again.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/fhandle.c