USB: serial: ark3116: fix open error handling
authorJohan Hovold <johan@kernel.org>
Thu, 12 Jan 2017 13:56:10 +0000 (14:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 May 2017 07:19:07 +0000 (09:19 +0200)
commit333c133c8f320f4f5dfe8d8c10fad5fcb343b51f
tree545ec83a8242de11333ec6772a37871353b200a1
parent150dbeaaa0b76f060e1a0bc6cc5169d6d9da4ac1
USB: serial: ark3116: fix open error handling

commit b631433b175f1002a31020e09bbfc2e5caecf290 upstream.

Fix open error handling which failed to detect errors when reading the
MSR and LSR registers, something which could lead to the shadow
registers being initialised from errnos.

Note that calling the generic close implementation is sufficient in the
error paths as the interrupt urb has not yet been submitted and the
register updates have not been made.

Fixes: f4c1e8d597d1 ("USB: ark3116: Make existing functions 16450-aware
and add close and release functions.")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/ark3116.c