clk: prevent erronous parsing of children during rate change
authorTero Kristo <t-kristo@ti.com>
Thu, 21 Aug 2014 13:47:45 +0000 (16:47 +0300)
committerJiri Slaby <jslaby@suse.cz>
Mon, 13 Oct 2014 13:41:41 +0000 (15:41 +0200)
commit3386c069c54344797c4d2da55ebef2f555a7a4a3
tree304268e068de9823599144ac86484b8c4d49381a
parent0dd03a746211ee0b7a901e382fdf8c15acbde80c
clk: prevent erronous parsing of children during rate change

commit 067bb1741c27c8d3b74ac98c0b8fc12b31e67005 upstream.

In some cases, clocks can switch their parent with clk_set_rate, for
example clk_mux can do this in some cases. Current implementation of
clk_change_rate uses un-safe list iteration on the clock children, which
will cause wrong clocks to be parsed in case any of the clock children
change their parents during the change rate operation. Fixed by using
the safe list iterator instead.

The problem was detected due to some divide by zero errors generated
by clock init on dra7-evm board, see discussion under
http://article.gmane.org/gmane.linux.ports.arm.kernel/349180 for details.

Fixes: 71472c0c06cf ("clk: add support for clock reparent on set_rate")
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reported-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/clk/clk.c