Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"
authorTakashi Iwai <tiwai@suse.de>
Sun, 24 May 2015 06:27:52 +0000 (08:27 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 10 Jun 2015 17:42:09 +0000 (13:42 -0400)
commit3c28d65e3835df1421d94cc57c77b26c9a1c3e44
tree3758183eb6b86e785026f170aba4a0f6f15e4ece
parent139cec161789dd64d0c4a1ff4dfd5eee852223af
Revert "ALSA: hda - Add mute-LED mode control to Thinkpad"

[ Upstream commit 3530febb5c7636f6b26d15637f68296804d26491 ]

This reverts commit 7290006d8c0900c56d8c58428134f02c35109d17.

Through the regression report, it was revealed that the
tpacpi_led_set() call to thinkpad_acpi helper doesn't only toggle the
mute LED but actually mutes the sound.  This is contradiction to the
expectation, and rather confuses user.

According to Henrique, it's not trivial to judge which TP model
behaves "LED-only" and which model does whatever more intrusive, as
Lenovo's implementations vary model by model.  So, from the safety
reason, we should revert the patch for now.

Reported-by: Martin Steigerwald <martin@lichtvoll.de>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
sound/pci/hda/thinkpad_helper.c