scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 28 Sep 2020 09:13:00 +0000 (12:13 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:48 +0000 (10:07 +0100)
commit3cdf3cbc3b48a34f4aa8404f8a62d15a03cdfbee
treee1583cbd53ef43e4923f69bc6d3f0d7411c26303
parent4c35763fbb0c4e98c85137a8c28e51f0a870a554
scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

[ Upstream commit 38b2db564d9ab7797192ef15d7aade30633ceeae ]

The be_fill_queue() function can only fail when "eq_vaddress" is NULL and
since it's non-NULL here that means the function call can't fail.  But
imagine if it could, then in that situation we would want to store the
"paddr" so that dma memory can be released.

Link: https://lore.kernel.org/r/20200928091300.GD377727@mwanda
Fixes: bfead3b2cb46 ("[SCSI] be2iscsi: Adding msix and mcc_rings V3")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/be2iscsi/be_main.c