of/device: Prevent buffer overflow in of_device_modalias()
authorBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 24 Aug 2017 01:04:04 +0000 (18:04 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Sep 2017 15:39:35 +0000 (17:39 +0200)
commit3ef5220bdba723f80b0654e58f5a8c05b739d34e
treea13fc3c1f0fdc18e9e845d216427ffbc63c534f6
parentaee0b37b710e8de6497bad31556750f6c02f0e26
of/device: Prevent buffer overflow in of_device_modalias()

commit 08ab58d9de3eb8498ae0585001d0975e46217a39 upstream.

As of_device_get_modalias() returns the number of bytes that would have
been written to the target string, regardless of how much did fit in the
buffer, it's possible that the returned index points beyond the buffer
passed to of_device_modalias() - causing memory beyond the buffer to be
null terminated.

Fixes: 0634c2958927 ("of: Add function for generating a DT modalias with a newline")
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/of/device.c