fscrypto: require write access to mount to set encryption policy
authorEric Biggers <ebiggers@google.com>
Thu, 8 Sep 2016 21:20:38 +0000 (14:20 -0700)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 3 Oct 2016 00:44:37 +0000 (20:44 -0400)
commit41beb77f7e59e17d675f159ae83c34b6545b7316
treefd1fdb687df6fffc3b943acf81bcd90b9a9186d4
parent08ac15d0e46bddb8dc9ae9bd939e844d7c2451b9
fscrypto: require write access to mount to set encryption policy

[ Upstream commit ba63f23d69a3a10e7e527a02702023da68ef8a6d ]

Since setting an encryption policy requires writing metadata to the
filesystem, it should be guarded by mnt_want_write/mnt_drop_write.
Otherwise, a user could cause a write to a frozen or readonly
filesystem.  This was handled correctly by f2fs but not by ext4.  Make
fscrypt_process_policy() handle it rather than relying on the filesystem
to get it right.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Cc: stable@vger.kernel.org # 4.1+; check fs/{ext4,f2fs}
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Acked-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
fs/ext4/ioctl.c