ext4: fix memory leak in ext4_xattr_set_acl()'s error path
authorEugene Shatokhin <eugene.shatokhin@rosalab.ru>
Thu, 8 Nov 2012 20:11:11 +0000 (15:11 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:11:28 +0000 (16:11 -0500)
commit41d4b0bae2fffc6558ac846199caee5baa8dd7f2
treed0cdc582deb49f375b46fd37f6234dd06e578e66
parent3b73beed27b6ad3877b7257ae17419930b8ae90c
ext4: fix memory leak in ext4_xattr_set_acl()'s error path

commit 24ec19b0ae83a385ad9c55520716da671274b96c upstream.

In ext4_xattr_set_acl(), if ext4_journal_start() returns an error,
posix_acl_release() will not be called for 'acl' which may result in a
memory leak.

This patch fixes that.

Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/ext4/acl.c