Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo
authorRoland Dreier <roland@purestorage.com>
Mon, 28 Mar 2011 21:13:35 +0000 (14:13 -0700)
committerAK <andi@firstfloor.org>
Thu, 31 Mar 2011 18:58:56 +0000 (11:58 -0700)
commit44736f7cc1e6fa539449f1327b6e88323e96de57
treef4c5b442efee1deb57ea24b5fa754d0f9ccf4a60
parentc8149a61de28892d8d28fd2180d1f9bbba2c9551
Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo

[ upstream commit 243b422 ]

Commit da48524eb206 ("Prevent rt_sigqueueinfo and rt_tgsigqueueinfo
from spoofing the signal code") made the check on si_code too strict.
There are several legitimate places where glibc wants to queue a
negative si_code different from SI_QUEUE:

 - This was first noticed with glibc's aio implementation, which wants
   to queue a signal with si_code SI_ASYNCIO; the current kernel
   causes glibc's tst-aio4 test to fail because rt_sigqueueinfo()
   fails with EPERM.

 - Further examination of the glibc source shows that getaddrinfo_a()
   wants to use SI_ASYNCNL (which the kernel does not even define).
   The timer_create() fallback code wants to queue signals with SI_TIMER.

As suggested by Oleg Nesterov <oleg@redhat.com>, loosen the check to
forbid only the problematic SI_TKILL case.

Reported-by: Klaus Dittrich <kladit@arcor.de>
Acked-by: Julien Tinnes <jln@google.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: <stable@kernel.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/signal.c