ipv6: remove rt6i_genid
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Sat, 27 Sep 2014 22:46:06 +0000 (00:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2014 10:05:29 +0000 (12:05 +0200)
commit46e9e43eeef323df23a45d577ea2a360617068ed
tree3c97f9acb3103b6bf7ab55e8cc626d438dc5f802
parent47a0965d9f9d263d2ab487f462f5d1827135cfdb
ipv6: remove rt6i_genid

[ Upstream commit 705f1c869d577c8055736dd02501f26a2507dd5b ]

Eric Dumazet noticed that all no-nonexthop or no-gateway routes which
are already marked DST_HOST (e.g. input routes routes) will always be
invalidated during sk_dst_check. Thus per-socket dst caching absolutely
had no effect and early demuxing had no effect.

Thus this patch removes rt6i_genid: fn_sernum already gets modified during
add operations, so we only must ensure we mutate fn_sernum during ipv6
address remove operations. This is a fairly cost extensive operations,
but address removal should not happen that often. Also our mtu update
functions do the same and we heard no complains so far. xfrm policy
changes also cause a call into fib6_flush_trees. Also plug a hole in
rt6_info (no cacheline changes).

I verified via tracing that this change has effect.

Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: YOSHIFUJI Hideaki <hideaki@yoshifuji.org>
Cc: Vlad Yasevich <vyasevich@gmail.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Martin Lau <kafai@fb.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/net/ip6_fib.h
include/net/net_namespace.h
net/ipv6/addrconf.c
net/ipv6/addrconf_core.c
net/ipv6/ip6_fib.c
net/ipv6/route.c