cfq-iosched: fix locking around ioc->ioc_data assignment
authorJens Axboe <jaxboe@fusionio.com>
Sun, 5 Jun 2011 04:01:13 +0000 (06:01 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 17 May 2012 15:21:00 +0000 (11:21 -0400)
commit470564b1d4c27fd2bafc421acf49718bfcf5ea5a
treea035f12836e0bfd8f97d450577cdaba1383ca182
parentb24a9d3db0f8d01f6c6088b2026f6739e5708ce1
cfq-iosched: fix locking around ioc->ioc_data assignment

commit ab4bd22d3cce6977dc039664cc2d052e3147d662 upstream.

Since we are modifying this RCU pointer, we need to hold
the lock protecting it around it.

This fixes a potential reuse and double free of a cfq
io_context structure. The bug has been in CFQ for a long
time, it hit very few people but those it did hit seemed
to see it a lot.

Tracked in RH bugzilla here:

https://bugzilla.redhat.com/show_bug.cgi?id=577968

Credit goes to Paul Bolle for figuring out that the issue
was around the one-hit ioc->ioc_data cache. Thanks to his
hard work the issue is now fixed.

Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
block/cfq-iosched.c