iscsi-target: Reject mutual authentication with reflected CHAP_C
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 6 Jun 2014 01:08:57 +0000 (18:08 -0700)
committerJiri Slaby <jslaby@suse.cz>
Mon, 23 Jun 2014 08:27:53 +0000 (10:27 +0200)
commit4eed5cf5e6d06f1ef7d786ed3f43da55112cb96c
tree149dfa4aa904a0dc8ac04ae9a512e95b57ee73f0
parentba576fd015636729ae6c55bd96f56014c2526571
iscsi-target: Reject mutual authentication with reflected CHAP_C

commit 1d2b60a5545942b1376cb48c1d55843d71e3a08f upstream.

This patch adds an explicit check in chap_server_compute_md5() to ensure
the CHAP_C value received from the initiator during mutual authentication
does not match the original CHAP_C provided by the target.

This is in line with RFC-3720, section 8.2.1:

   Originators MUST NOT reuse the CHAP challenge sent by the Responder
   for the other direction of a bidirectional authentication.
   Responders MUST check for this condition and close the iSCSI TCP
   connection if it occurs.

Reported-by: Tejas Vaykole <tejas.vaykole@calsoftinc.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/target/iscsi/iscsi_target_auth.c