mISDN: fix possible use-after-free in HFC_cleanup()
authorZou Wei <zou_wei@huawei.com>
Tue, 11 May 2021 06:58:53 +0000 (14:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:21:06 +0000 (16:21 +0200)
commit54ff3202928952a100c477248e65ac6db01258a7
tree6dcf05f01d65a1ffc61917934d83b6ee2a34f303
parenta832ee2f2145f57443b2d565f8cb5490e8339f42
mISDN: fix possible use-after-free in HFC_cleanup()

[ Upstream commit 009fc857c5f6fda81f2f7dd851b2d54193a8e733 ]

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/isdn/hardware/mISDN/hfcpci.c