ALSA: prevent heap corruption in snd_ctl_new()
authorDan Rosenberg <drosenberg@vsecurity.com>
Tue, 28 Sep 2010 18:18:20 +0000 (14:18 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:04:14 +0000 (21:04 -0700)
commit56b40aa2ea3788e9b8f8411868f0f35a6f8a14cf
treebec88e5901763f40cb5e1dc7245924f800faa4a5
parent7b1178dc25f59d6f61dc87853d164e8ec87eba25
ALSA: prevent heap corruption in snd_ctl_new()

commit 5591bf07225523600450edd9e6ad258bb877b779 upstream.

The snd_ctl_new() function in sound/core/control.c allocates space for a
snd_kcontrol struct by performing arithmetic operations on a
user-provided size without checking for integer overflow.  If a user
provides a large enough size, an overflow will occur, the allocated
chunk will be too small, and a second user-influenced value will be
written repeatedly past the bounds of this chunk.  This code is
reachable by unprivileged users who have permission to open
a /dev/snd/controlC* device (on many distros, this is group "audio") via
the SNDRV_CTL_IOCTL_ELEM_ADD and SNDRV_CTL_IOCTL_ELEM_REPLACE ioctls.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
sound/core/control.c