Bluetooth: qca: fix firmware check error path
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 1 May 2024 06:37:40 +0000 (08:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2024 09:51:06 +0000 (11:51 +0200)
commit580bcd6bf24f9975f97d81d5ef1b64cca9240df9
treebdf8719c72962ccdb1b2de88225df3927c895b88
parentb91390f4e828fd2cd6ba51c943c3661cbb0c45d0
Bluetooth: qca: fix firmware check error path

commit 40d442f969fb1e871da6fca73d3f8aef1f888558 upstream.

A recent commit fixed the code that parses the firmware files before
downloading them to the controller but introduced a memory leak in case
the sanity checks ever fail.

Make sure to free the firmware buffer before returning on errors.

Fixes: f905ae0be4b7 ("Bluetooth: qca: add missing firmware sanity checks")
Cc: stable@vger.kernel.org # 4.19
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bluetooth/btqca.c