rtnetlink: Warn when interface's information won't fit in our packet
authorDavid Gibson <david@gibson.dropbear.id.au>
Thu, 24 Apr 2014 00:22:35 +0000 (10:22 +1000)
committerJiri Slaby <jslaby@suse.cz>
Thu, 29 May 2014 09:49:18 +0000 (11:49 +0200)
commit5a6aea7c0eaa0a2a851f80aa646ebb65d76c51fe
treebf627c9acd132d09f086c3cf14aef64a942b1a1f
parent6bebcc8d95669e32c9ac6e836e985ae50392ae23
rtnetlink: Warn when interface's information won't fit in our packet

[ Upstream commit 973462bbde79bb827824c73b59027a0aed5c9ca6 ]

Without IFLA_EXT_MASK specified, the information reported for a single
interface in response to RTM_GETLINK is expected to fit within a netlink
packet of NLMSG_GOODSIZE.

If it doesn't, however, things will go badly wrong,  When listing all
interfaces, netlink_dump() will incorrectly treat -EMSGSIZE on the first
message in a packet as the end of the listing and omit information for
that interface and all subsequent ones.  This can cause getifaddrs(3) to
enter an infinite loop.

This patch won't fix the problem, but it will WARN_ON() making it easier to
track down what's going wrong.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/core/rtnetlink.c