nvme-tcp: fix possible use-after-free in transport error_recovery work
authorSagi Grimberg <sagi@grimberg.me>
Tue, 1 Feb 2022 12:54:20 +0000 (14:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Feb 2022 10:59:56 +0000 (11:59 +0100)
commit61a26ffd5ad3ece456d74c4c79f7b5e3f440a141
treea16418efb1a609fd2d7c40061e3388c8050dde17
parent70356b756a58704e5c8818cb09da5854af87e765
nvme-tcp: fix possible use-after-free in transport error_recovery work

[ Upstream commit ff9fc7ebf5c06de1ef72a69f9b1ab40af8b07f9e ]

While nvme_tcp_submit_async_event_work is checking the ctrl and queue
state before preparing the AER command and scheduling io_work, in order
to fully prevent a race where this check is not reliable the error
recovery work must flush async_event_work before continuing to destroy
the admin queue after setting the ctrl state to RESETTING such that
there is no race .submit_async_event and the error recovery handler
itself changing the ctrl state.

Tested-by: Chris Leech <cleech@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/tcp.c