locking/rtmutex: Avoid a NULL pointer dereference on deadlock
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 17 Feb 2015 15:43:43 +0000 (16:43 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 24 Mar 2015 01:02:44 +0000 (21:02 -0400)
commit636697380e1189b5385aeef9b022a3a65024fba9
tree5b8fdd6bddbb783823fa10c51daf37b6129eb1e1
parente055b8cf3331da106a9ba9457a74576a563e0455
locking/rtmutex: Avoid a NULL pointer dereference on deadlock

commit 8d1e5a1a1ccf5ae9d8a5a0ee7960202ccb0c5429 upstream.

With task_blocks_on_rt_mutex() returning early -EDEADLK we never
add the waiter to the waitqueue. Later, we try to remove it via
remove_waiter() and go boom in rt_mutex_top_waiter() because
rb_entry() gives a NULL pointer.

( Tested on v3.18-RT where rtmutex is used for regular mutex and I
  tried to get one twice in a row. )

Not sure when this started but I guess 397335f004f4 ("rtmutex: Fix
deadlock detector for real") or commit 3d5c9340d194 ("rtmutex:
Handle deadlock detection smarter").

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1424187823-19600-1-git-send-email-bigeasy@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
kernel/locking/rtmutex.c