microblaze: Fix /dev/zero corruption from __clear_user()
authorSteven J. Magnani <steve@digidescorp.com>
Thu, 10 Feb 2011 18:12:13 +0000 (12:12 -0600)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 Mar 2011 19:50:08 +0000 (12:50 -0700)
commit643023b097159a1d887278b0e84b30cd19de8ca0
tree41d69fc223e0dc07a45f68a66e415355f227c7bb
parentded2c8bd9568be9dc8bfacaf63927b8b624737da
microblaze: Fix /dev/zero corruption from __clear_user()

commit 6f3946b421395ff853bc0bcdab9c26b50ebbba8f upstream.

A userland read of more than PAGE_SIZE bytes from /dev/zero results in
(a) not all of the bytes returned being zero, and
(b) memory corruption due to zeroing of bytes beyond the user buffer.

This is caused by improper constraints on the assembly __clear_user function.
The constrints don't indicate to the compiler that the pointer argument is
modified. Since the function is inline, this results in double-incrementing
of the pointer when __clear_user() is invoked through a multi-page read() of
/dev/zero.

Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
Acked-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/microblaze/include/asm/uaccess.h