nfs d_revalidate() is too trigger-happy with d_drop()
authorAl Viro <viro@ZenIV.linux.org.uk>
Thu, 29 Apr 2010 02:10:43 +0000 (03:10 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 May 2010 22:02:40 +0000 (15:02 -0700)
commit656fdb1f49706d82e37df3488fc525490f8cca83
tree553e68665632bb97f29cc116553fc2d01c651a86
parent1ff21ff30e324d2e994a54baf9dc3df003985b60
nfs d_revalidate() is too trigger-happy with d_drop()

commit d9e80b7de91db05c1c4d2e5ebbfd70b3b3ba0e0f upstream.

If dentry found stale happens to be a root of disconnected tree, we
can't d_drop() it; its d_hash is actually part of s_anon and d_drop()
would simply hide it from shrink_dcache_for_umount(), leading to
all sorts of fun, including busy inodes on umount and oopsen after
that.

Bug had been there since at least 2006 (commit c636eb already has it),
so it's definitely -stable fodder.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/nfs/dir.c