nfp: abm: fix a memory leak bug
authorQiushi Wu <wu000273@umn.edu>
Sat, 2 May 2020 22:42:59 +0000 (17:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 May 2020 05:58:22 +0000 (07:58 +0200)
commit66f7e30273efe785258f74a4a5c61e1e2e8c8e6d
tree3058242bb6455ed2dd380a87e3918af3b139b723
parent8fc441d1618365415cd7b119a871169a9894ade0
nfp: abm: fix a memory leak bug

[ Upstream commit bd4af432cc71b5fbfe4833510359a6ad3ada250d ]

In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
which can lead to a memory leak bug. Fix this issue by adding
nfp_nsp_close(nsp) in the error path.

Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/netronome/nfp/abm/main.c