EVM: Use crypto_memneq() for digest comparisons
authorRyan Ware <ware@linux.intel.com>
Thu, 11 Feb 2016 23:58:44 +0000 (15:58 -0800)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 4 Mar 2016 15:18:41 +0000 (10:18 -0500)
commit6702fc0c98d40442f9e74e10c499d68cd96455df
treeeb8694a96d551c669f5c9e057b13f16ee831a4f9
parentb42e89beb60b3b618b180349a0e3b02ae3d4657e
EVM: Use crypto_memneq() for digest comparisons

[ Upstream commit 613317bd212c585c20796c10afe5daaa95d4b0a1 ]

This patch fixes vulnerability CVE-2016-2085.  The problem exists
because the vm_verify_hmac() function includes a use of memcmp().
Unfortunately, this allows timing side channel attacks; specifically
a MAC forgery complexity drop from 2^128 to 2^12.  This patch changes
the memcmp() to the cryptographically safe crypto_memneq().

Reported-by: Xiaofei Rex Guo <xiaofei.rex.guo@intel.com>
Signed-off-by: Ryan Ware <ware@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
security/integrity/evm/evm_main.c