KVM: ARM: vgic: Fix the overlap check action about setting the GICD & GICC base address.
authorHaibin Wang <wanghaibin.wang@huawei.com>
Tue, 29 Apr 2014 06:49:17 +0000 (14:49 +0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 30 Apr 2015 09:15:06 +0000 (11:15 +0200)
commit68779c62b1d0d0af82077e6ff03140e3fd24f940
tree7f49bb0dab8205ea70b32dabea1dbbc76a3eeba5
parentbc1a23b6ed483568e8443647e9afdcadee2dca5e
KVM: ARM: vgic: Fix the overlap check action about setting the GICD & GICC base address.

commit 30c2117085bc4e05d091cee6eba79f069b41a9cd upstream.

Currently below check in vgic_ioaddr_overlap will always succeed,
because the vgic dist base and vgic cpu base are still kept UNDEF
after initialization. The code as follows will be return forever.

if (IS_VGIC_ADDR_UNDEF(dist) || IS_VGIC_ADDR_UNDEF(cpu))
                return 0;

So, before invoking the vgic_ioaddr_overlap, it needs to set the
corresponding base address firstly.

Signed-off-by: Haibin Wang <wanghaibin.wang@huawei.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
virt/kvm/arm/vgic.c