netfilter: ipset: Fix forceadd evaluation path
authorJozsef Kadlecsik <kadlec@netfilter.org>
Sat, 22 Feb 2020 11:01:43 +0000 (12:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:43:44 +0000 (16:43 +0100)
commit6c717726f341fd8f39a3ec2dcf5d98d9d28a2769
tree7c37788a851308f2310d5cc369cc8be5f44cfc7a
parentf09fbb1175cffdbbb36b28e2ff7db96dcc90de08
netfilter: ipset: Fix forceadd evaluation path

commit 8af1c6fbd9239877998c7f5a591cb2c88d41fb66 upstream.

When the forceadd option is enabled, the hash:* types should find and replace
the first entry in the bucket with the new one if there are no reuseable
(deleted or timed out) entries. However, the position index was just not set
to zero and remained the invalid -1 if there were no reuseable entries.

Reported-by: syzbot+6a86565c74ebe30aea18@syzkaller.appspotmail.com
Fixes: 23c42a403a9c ("netfilter: ipset: Introduction of new commands and protocol version 7")
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/ipset/ip_set_hash_gen.h