SCSI: aha152x: fix init suspiciously returned 1, it should follow 0/-E convention
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 13 May 2008 19:10:24 +0000 (19:10 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 15 May 2008 14:50:08 +0000 (07:50 -0700)
commit6cbde20dcd3ea3df46ac545d59fc4da6b1e9487a
tree82dfd6abd72c167c6087788ed916096ea3a523bd
parent22f995e70a88761b1f15cb0bec8eb79ccf7e0a60
SCSI: aha152x: fix init suspiciously returned 1, it should follow 0/-E convention

commit ad2fa42d044b98469449880474a9662fb689f7f9 upstream

Reported-by: Frank de Jong <frapex@xs4all.nl>
> [1.] One line summary of the problem:
> linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should
> follow 0/-E convention. The module / driver works okay. Unloading the
> module is impossible.

The driver is apparently returning 0 on failure and 1 on success.
That's a bit unfortunate.  Fix it by altering to -ENODEV and 0.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/aha152x.c