staging: comedi: pcmuio: fix possible NULL deref on detach
authorIan Abbott <abbotti@mev.co.uk>
Tue, 20 Aug 2013 10:50:19 +0000 (11:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Dec 2013 15:34:21 +0000 (07:34 -0800)
commit70a9deaa57ee1572c95dce7ec1991bf018728f3a
tree5669b2acfc49a092d39eb154fb7e2ac53ed43911
parente71859894bfd0ceaf65e98bf287478242d17a9ec
staging: comedi: pcmuio: fix possible NULL deref on detach

commit 2fd2bdfccae61efe18f6b92b6a45fbf936d75b48 upstream.

pcmuio_detach() is called by the comedi core even if pcmuio_attach()
returned an error, so `dev->private` might be `NULL`.  Check for that
before dereferencing it.

Also, as pointed out by Dan Carpenter, there is no need to check the
pointer passed to `kfree()` is non-NULL, so remove that check.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/pcmuio.c