libceph: don't bail early from try_read() when skipping a message
authorIlya Dryomov <idryomov@gmail.com>
Wed, 17 Feb 2016 19:04:08 +0000 (20:04 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 3 Mar 2016 11:46:05 +0000 (12:46 +0100)
commit715a01aa261cd312c2aaa8614eadd6b28fd3a018
tree8634ed9b3f22e07f037bd894389860775cbb4dcc
parentc40612ad30e2381d46627e888fd7d945c1cb5b7e
libceph: don't bail early from try_read() when skipping a message

commit e7a88e82fe380459b864e05b372638aeacb0f52d upstream.

The contract between try_read() and try_write() is that when called
each processes as much data as possible.  When instructed by osd_client
to skip a message, try_read() is violating this contract by returning
after receiving and discarding a single message instead of checking for
more.  try_write() then gets a chance to write out more requests,
generating more replies/skips for try_read() to handle, forcing the
messenger into a starvation loop.

Reported-by: Varada Kari <Varada.Kari@sandisk.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Tested-by: Varada Kari <Varada.Kari@sandisk.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/ceph/messenger.c