KEYS: Change the name of the dead type to ".dead" to prevent user access
authorDavid Howells <dhowells@redhat.com>
Tue, 18 Apr 2017 14:31:08 +0000 (15:31 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 9 May 2017 06:19:31 +0000 (08:19 +0200)
commit716aa8781692706c78bea54b1efd4269d15d4071
tree03689f9a3d73a5980c4814f5f8f436dbfa6c26f7
parent7c46e24ef54c73c7db075d3ff4df0d3b996ac759
KEYS: Change the name of the dead type to ".dead" to prevent user access

commit c1644fe041ebaf6519f6809146a77c3ead9193af upstream.

This fixes CVE-2017-6951.

Userspace should not be able to do things with the "dead" key type as it
doesn't have some of the helper functions set upon it that the kernel
needs.  Attempting to use it may cause the kernel to crash.

Fix this by changing the name of the type to ".dead" so that it's rejected
up front on userspace syscalls by key_get_type_from_user().

Though this doesn't seem to affect recent kernels, it does affect older
ones, certainly those prior to:

commit c06cfb08b88dfbe13be44a69ae2fdc3a7c902d81
Author: David Howells <dhowells@redhat.com>
Date:   Tue Sep 16 17:36:06 2014 +0100
KEYS: Remove key_type::match in favour of overriding default by match_preparse

which went in before 3.18-rc1.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
security/keys/gc.c