net/mlx5: DR, fix a potential use-after-free bug
authorWentao_Liang <Wentao_Liang_g@163.com>
Thu, 19 Aug 2021 14:30:05 +0000 (22:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:42:19 +0000 (13:42 +0200)
commit71d2ef43cb52acf754de7ae91f54b2f244b02661
treeb5ab7e34c3777f429440d5f27f789d01f848e32e
parent6b5b94b419f74788e07820c9cc63cd97c668513b
net/mlx5: DR, fix a potential use-after-free bug

[ Upstream commit 6cc64770fb386b10a64a1fe09328396de7bb5262 ]

In line 849 (#1), "mlx5dr_htbl_put(cur_htbl);" drops the reference to
cur_htbl and may cause cur_htbl to be freed.

However, cur_htbl is subsequently used in the next line, which may result
in an use-after-free bug.

Fix this by calling mlx5dr_err() before the cur_htbl is put.

Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c