ptrace: restore smp_rmb() in __ptrace_may_access()
authorJann Horn <jannh@google.com>
Wed, 29 May 2019 11:31:57 +0000 (13:31 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 5 Oct 2019 15:19:55 +0000 (16:19 +0100)
commit74c41ea7b30fb43819b2d7c314c4c28dd9cb1761
tree03baa292b4485c43094e3502a85eb57a66aadd81
parentc03cd5758090d132a168a83984bc69e66350e59b
ptrace: restore smp_rmb() in __ptrace_may_access()

commit f6581f5b55141a95657ef5742cf6a6bfa20a109f upstream.

Restore the read memory barrier in __ptrace_may_access() that was deleted
a couple years ago. Also add comments on this barrier and the one it pairs
with to explain why they're there (as far as I understand).

Fixes: bfedb589252c ("mm: Add a user_ns owner to mm_struct and fix ptrace permission checks")
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/cred.c
kernel/ptrace.c