drivers/mailbox/omap: make mbox->irq signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 23 Jan 2014 23:53:45 +0000 (15:53 -0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 30 Jul 2015 12:10:58 +0000 (14:10 +0200)
commit7562c6fb07eadc6d0d9b6643dadad3d20af4d867
treed966f408dddb0881ec9d8a582fc44b1dfc1d2b7b
parentfe2a2e06fd8af3a00d18691ffeb2b636f685bee4
drivers/mailbox/omap: make mbox->irq signed for error handling

commit 4a102b4d144f0422eb8b0a59c7cb194bf12163a9 upstream.

There is a bug in omap2_mbox_probe() where we try do:

mbox->irq = platform_get_irq(pdev, info->irq_id);
if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oliver Neukum <ONeukum@suse.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/mailbox/omap-mbox.h