net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 27 Mar 2012 09:53:52 +0000 (09:53 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Apr 2012 17:32:23 +0000 (10:32 -0700)
commit7731184bff478c662868361f275c640d16fd3ef0
treed47b32fdfff121b2674b0244caac24f2ffee57b2
parent145eb310bda7e0d583b8c44e7b5fbaae7be2db24
net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()

[ Upstream commit 94f826b8076e2cb92242061e92f21b5baa3eccc2 ]

Commit f2c31e32b378 (net: fix NULL dereferences in check_peer_redir() )
added a regression in rt6_fill_node(), leading to rcu_read_lock()
imbalance.

Thats because NLA_PUT() can make a jump to nla_put_failure label.

Fix this by using nla_put()

Many thanks to Ben Greear for his help

Reported-by: Ben Greear <greearb@candelatech.com>
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv6/route.c